test options for custom icons and labels - #4981
Conversation
myovchev
left a comment
There was a problem hiding this comment.
Please see the comment on the checkbox item help vs htmlHelp.
| <p | ||
| v-if="(choice.help || choice.htmlHelp)" | ||
| class="apos-choice-label-text--help apos-field__help" | ||
| v-html="$t(choice.help || choice.htmlHelp)" |
There was a problem hiding this comment.
Choice help should not be rendered as HTML unlike htmlHelp. I think you need two separate entries and checks for this render.
There was a problem hiding this comment.
This code was carried over from AposInputWrapper.vue#105.
| value: wizard.values.translateContent.data, | ||
| label: $t('apostrophe:automaticTranslationCheckbox') | ||
| label: $t('apostrophe:automaticTranslationCheckbox'), | ||
| htmlHelp: $t('apostrophe:automaticTranslationCheckboxHelp') |
There was a problem hiding this comment.
Are we sure that i18n is not encoding HTML?
There was a problem hiding this comment.
We do it already and it seems to work, for example i18n/en.json#54
|
I also forgot to mention - we need a CHANGELOG entry explaining that |
stuartromanek
left a comment
There was a problem hiding this comment.
I don't think it makes sense for them to change or confuse the modifiers prop
I tried to match the screenshots in the original ticket https://apostrophetechnologies.zendesk.com/agent/tickets/1317 |
I just don't think it makes sense. What those modifiers do is not documented or previewable. Why don't we give them a prop to apply a class to the overridden element so that they can further refine it in their own front-end? |
* main: Fix login tests for whoami route. (#4991) Implemented API endpoint to return current users info (#4872) Fix field options and allow import image tags (#4988) Fix wrapper class when no base class is set (#4986) Ensure defaultNode has highest priority (#4985) PRO-7811: Rich text modified state not detected correctly by the backend (#4982) Ensure convert doesn't fail on its own (#4983) Pro 7831 dynamic choices for piece manager filters (#4969) PRO-7797: revert deps (#4976)
Good idea, I'm working on it |
|
Please don't wait for my review on this, I think we have a good quorum of reviewers on it |
|
@stuartromanek I did the requested change with the class. |
Summary
Allow to customize icons and labels for AI
What are the specific steps to test this change?
This requires
@apostrophecms-pro/seo-assistantand@apostrophecms-pro/automatic-translationfollowing the doc https://github.com/apostrophecms/seo-assistant/modules/@apostrophecms/i18n/i18n/en.jsonmodules/@apostrophecms-pro/automatic-translation/i18n/en.jsonmodules/@apostrophecms/seo-assistant-doc-type/index.jsmodules/asset/ui/src/index.scsswithWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: